[evcc] Fix missing grid readings after evcc breaking change in 0.133.0 #18199
+78
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#18148 Signed-off-by: Daniel Kötting <[email protected]>
|
Can we spend the extra effort and implement this change backward compatible? Allowing the old and the new location of the grid values? |
|
Might Work. I will have a look later and try to implement it with a quick version check.
|
Fixes openhab#18148 Signed-off-by: Daniel Kötting <[email protected]>
|
I have added the workaround and testet with evcc 0.131.5 and 0.133.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18148
This PR fixes the new alignment of grid data comming from evccs /api/state endpoint.
The old and new structure can be seen in this conversation over at evcc evcc-io/evcc#18063
This change is not backwards compatible with older versions of evcc.